Skip to content

Add "alarm", "copy", and "hook" icons #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 24, 2020
Merged

Conversation

vine77
Copy link
Contributor

@vine77 vine77 commented Mar 24, 2020

Ticket: https://tickets.puppetlabs.com/browse/PN-589

  • Add "alarm", "copy", and "hook" icons
  • Unrelated: Quick fix for wide tab panels pushing container too wide

Screen Shot 2020-03-24 at 11 02 28 AM

Screen Shot 2020-03-24 at 11 02 39 AM

Screen Shot 2020-03-24 at 11 02 46 AM

@vine77 vine77 requested a review from sebastian-adam March 24, 2020 18:04
@vine77 vine77 requested a review from a team as a code owner March 24, 2020 18:04
@vine77 vine77 force-pushed the add-icons-hook-alarm-copy branch from e89d88b to d24a476 Compare March 24, 2020 18:07
@@ -5,6 +5,7 @@
flex: 1;
flex-direction: column;
margin-top: $puppet-common-spacing-base * 4;
width: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you did max-width: 100%? Would be more safe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Okay, it's max-width: 100% now.

@vine77 vine77 force-pushed the add-icons-hook-alarm-copy branch from 43606f6 to 7adc66e Compare March 24, 2020 19:33
Copy link
Contributor

@nmuldavin nmuldavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vine77 vine77 merged commit 3ff23e3 into master Mar 24, 2020
@vine77 vine77 deleted the add-icons-hook-alarm-copy branch March 24, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants