Remove margin from Badge component

[vine77]

The left/right outer margins for Badge are inconsistent with our other components that don't have any outer margin. We otherwise require the consumer to set margins between components. This change will require any consumers relying on this behavior to add the margins to their consuming app.

This issue was noticed by me in nebula-ui where a Badge got overly indented due to not removing these margins and by @sprokusk in relay-website who overrode this margin to 0.

The only exception to react-components specifying margins is in _button.scss#L356-L358 but that is strictly adding margins only between multiple Buttons components.

[vine77]

I would be fine doing something similar to Button if the intention was just to add margin between Badge components:

.rc-badge + .rc-badge {
  margin-left: $puppet-common-spacing-base;
}

[caseywilliams]

I think we may already override this on the Forge, but even if we don't I'm 👍 (I don't feel strongly either way about the + rule you mention)

[vine77]

Just talked to Sig who said that the intention was to get spacing between badges and approved the adjacent sibling selector approach, so I just pushed a commit for that.

Thanks for approving Casey!