Maint - moving react into dev dependency #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jilliankeenan
commented
Apr 15, 2020
•
jilliankeenan
commented
- react and react-dom were being declared as a hard dependency in the data grid and also react-components moving these into peer dependencies and dev dependency
- doing the same for data-grid and removing storybook
…data grid removing storybook also
jilliankeenan
added
dependencies
|
Thanks @jilliankeenan. It does seem like having multiple versions of react dependencies could cause problems, so this seems like a good idea to me. Thanks for pinging me, and I'm glad to hear this would resolve the issues you're having in the estate reporting UI. I just released @puppet/[email protected] and @puppet/[email protected] for testing purposes. |
|
Would you mind doing the same thing with @puppet/react-layouts? |
|
Thanks! I released @puppet/[email protected] and will give them a test in the Relay apps. Will merge this in a day or so to give folks a chance to raise any concerns. |
vine77
approved these changes
Apr 21, 2020
|
Released in @puppet/[email protected], @puppet/[email protected], and @puppet/[email protected]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.