Add innerClassName prop to Form.Field
#261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vine77
force-pushed
the
tasks/add-formfield-class
branch
from
f43adc0 to
c629c88
Compare
nmuldavin
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
This looks good. The only consideration is that it technically makes it required that Form input component implementations correctly handle a className prop as part of the interface described here: https://puppet.style/#/React%20Components/FormField
I think this should be the case already with all of our implementations
|
It looks like I need to update a test: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
classNamegets applied to the wrapping div, so adding aninnerClassNameallows us to target the inner form field element.Note: This is a prerequisite for PN-1002