Added Wendy's star icons #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i really should remember to test locally first |
|
@caseywilliams Are you using the "star" icon in the Forge? Nik added it in #226 (but it is a star in a box whereas these are just a solid and outlined star). |
|
@vine77 yeah, there are multiple star styles in use on the Forge redesigns |
vine77
force-pushed
the
task/add-star-icons
branch
from
fda588c to
72903f1
Compare
vine77
force-pushed
the
task/add-star-icons
branch
from
72903f1 to
da36a54
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new star icons per @wendy-oh and the Estate Reporting team.
This should fulfill their needs. Note that these icons are different than the
staricon. That is in use by the forge and has a box around it. We didn't want to overwrite their icon so we've used the new suffixes to indicate the differences. We may want to deprecatestarin 2.0.