(PDS-448) add size and shape props to input component #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/react-components/source/scss/library/components/forms/_input.scss
Outdated
Show resolved
Hide resolved
| <Input | ||
| name="input-ex7" | ||
| value={state.value} | ||
| placeholder="blueberry spicehead" |
There was a problem hiding this comment.
this is my favorite Input
sebastian-adam
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
I approve this if you'd like to get it in separately, but would you create another ticket or include another commit here that makes the icon in the input part of the same click area? I know you didn't introduce it, but the icon doesn't respond to hover or click.
melcherry98
force-pushed
the
PDS-448-input-updates
branch
from
1037fa1 to
1ac0632
Compare
ticketed in https://tickets.puppetlabs.com/browse/PDS-552 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "medium" and "large" as available size options and "squared" and "rounded" as shape options.
