(MAINT) Add onUpdate prop to filter #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Can we create an accompanying unit test to cover the change? |
vine77
approved these changes
Oct 22, 2020
peculiarism
force-pushed
the
maint/onupdate-filter-prop
branch
from
79f958c to
2b698f6
Compare
This was referenced Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Remediate we have moved from using a
StringFilterto aStringArrayFilterfor one of our table fields. With current filter behaviour we wouldn't be able to apply filtering on this value, which is a requirement from Product (we already useSimpleFiltersin the majority of your views for other fields, otherwise we would utilise that). Adding theonUpdateprop allows relevant operators and fields to be changed in the HOC in a case where a field with aStringArrayFilteris used. Also could be used to supply additional operators/fields for other complex filtering.