(PDS-566) Add prop to Tag component to show/hide button

[jilliankeenan]

This PR adds an additional prop hideRemoveButton to the tag component - for cases where you just want to display a static tag without giving the ability to the user to remove it.

[eputnam]

LGTM.

Had we considered making the prop static instead of hideRemoveButton? I'm just thinking about this being a future construct across components that means it can't be acted on. I guess that can be addressed further down the road and i do appreciate a prop that says exactly what it's doing.

[jilliankeenan]

LGTM.

Had we considered making the prop static instead of hideRemoveButton? I'm just thinking about this being a future construct across components that means it can't be acted on. I guess that can be addressed further down the road and i do appreciate a prop that says exactly what it's doing.

Yea I felt it was more obvious what the prop was doing by naming it hideRemoveButton but you've made a really good point for example in the SidePanel I implemented a similar functionality where the user can show/hide the close button. Perhaps if we adopted static as the prop name for these cases design system wide it would make more sense for each individual component in this case.