Skip to content

Allow disabling items in Select components #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 10, 2021
Merged

Allow disabling items in Select components #366

merged 7 commits into from
Feb 10, 2021

Conversation

Lukeaber
Copy link
Collaborator

Screenshot 2020-11-27 at 15 18 24

@Lukeaber Lukeaber requested a review from a team as a code owner November 27, 2020 15:21
Lukeaber and others added 2 commits November 30, 2020 16:20
@Lukeaber @jilliankeenan
Fix comment
2d26bf5 
Co-authored-by: Jillian Keenan <[email protected]>
@Lukeaber
Fix linter
6309e61
@vine77
Copy link
Contributor

vine77 commented Nov 30, 2020

If we're adding disabled to ActionSelect items, should we do the same for Select and ButtonSelect?

@Lukeaber
Copy link
Collaborator Author

Lukeaber commented Dec 1, 2020 •
edited
Loading

If we're adding disabled to ActionSelect items, should we do the same for Select and ButtonSelect?

Not sure, estate reporting got a design that required this to be added to the actionSelect but theres nothing for the button select or standard select that ive seen.

@vine77
Copy link
Contributor

vine77 commented Dec 1, 2020

Do you know how much work it would be to also add disabled to the other Select components? There is some benefit in making features symmetrical across components. Not sure if they would share any code. Seems valid to have an item be disabled in any type of dropdown.

@vine77 vine77 changed the title Action select disable row Allow disabling items in Select components Feb 10, 2021
@vine77 vine77 force-pushed the Action-Select-disable-row branch from 2ee5a5d to 5a9f4c8 Compare February 10, 2021 16:44
melcherry98
melcherry98 approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@melcherry98 melcherry98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vine77 vine77 merged commit 5cff708 into development Feb 10, 2021
@vine77 vine77 deleted the Action-Select-disable-row branch February 10, 2021 16:48
@vine77 vine77 mentioned this pull request Feb 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilliankeenan jilliankeenan jilliankeenan left review comments

@melcherry98 melcherry98 melcherry98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lukeaber @vine77 @jilliankeenan @melcherry98