Use min-width and min-height in Card examples #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to change this or add note about a11y guidelines. |
steveax
reviewed
Mar 9, 2021
| @@ -9,8 +9,8 @@ import Heading from '../heading'; | |||
| import Text from '../text'; | |||
|
|
|||
| const cardExampleStyle = { | |||
| width: 150, | |||
| height: 150, | |||
| minWidth: 150, | |||
There was a problem hiding this comment.
Not sure that the width needs changing (at least in the case of the value report in PE the text reflowed fine WRT width), it's mainly the height that's the issue as the contents will overflow pretty quickly when only the text is re-sized.
vine77
force-pushed
the
tasks/card-fixed-size-examples
branch
from
bd46eec to
a89ccad
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@steveax pointed out a11y issues with fixed Card sizing: WCAG 2.1 Success Criterion 1.4.4: Resize text