(PDS-584) Add mechanism for force updating Overlay #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `show` prop to allow a string so that the Overaly can be updated if the value of `show` changes. This is useful if the UI shifts and the target is not in the same position as it was when the overlay was created.
chrisleicester
approved these changes
Apr 12, 2021
|
@mardotio and I are trying to get the website to run locally before deploying these changes (with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Overlayposition has no way to be updated if the original target movedNew Behavior
Overlaycan be forced to recalculate its position by providing a new string value forshowPosition Change Example
Screen.Recording.2021-04-08.at.1.32.28.PM.mov