Skip to content

Add Alerts component #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2021
Merged

Conversation

vine77
Copy link
Contributor

@vine77 vine77 commented May 5, 2021

Resolves PDS-585

  • Add Alerts component, a container component to which you can pass a collection of Alert components to display them as floating "growl" notifications.
  • Add documentation with a couple examples.

Screen Shot 2021-05-05 at 9 04 37 AM

@vine77 vine77 requested a review from a team as a code owner May 5, 2021 16:08
@vine77 vine77 requested a review from mardotio May 5, 2021 16:38
@vine77
Copy link
Contributor Author

vine77 commented May 5, 2021

I’m open to suggestions for other variants of this if it would be helpful to have a non-floating version or bottom-right placement option.

Copy link
Contributor

@mardotio mardotio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. For what we need them we only need them to show up in the upper right corner, but it seems like it should be easy enough to add other positions is we ever need them.
Thanks for getting this done!

@vine77 vine77 merged commit d30a05c into development May 6, 2021
@vine77 vine77 deleted the tasks/PDS-585-upstream-notifications branch May 6, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants