(CISC-1585) Select all with pagination, new icons, check all empty st… #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukeaber
force-pushed
the
CISC-1585-DataGrid-Improvements
branch
2 times, most recently
from
02ca876 to
e6e6179
Compare
| children | ||
| )} | ||
| <div className="dg-table-header-text-container"> | ||
| {children === undefined ? ( |
There was a problem hiding this comment.
test this out but think it can be !children
|
All looks good apart from minor comment |
…ate bug fix, table actions
Lukeaber
force-pushed
the
CISC-1585-DataGrid-Improvements
branch
from
e6e6179 to
c76f516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ate bug fix, table actions
Okay sorry there's quite a few changes in the one pr but these are changes needed for the latest comply feature.
1st change: in packages/data-grid/src/table/README.md i changes the ```sh shell to be '''markdown as this is supported by styleguidest and removes console warnings in the pds build.
2nd change: i added 3 new icons
3rd change: Added Table actions
4th change: Select all with pagination pattern
5th change: Small empty state bug where the table header select all checkbox would be intermediate state when it should be empty
Will push a release pr for both the react components and datagrid after just a lot in this one already