(CDPE-4655) Add tooltip to Sidebar.Footer #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, if the Sidebar Footer was used and the sign-out button was present, there was no way to add a tooltip to explain the usage of this button. This makes it difficult for someone using a screen reader to find this button and use it. With this commit, we add an optional parameter to the Sidebar Footer to specify tooltip text. If specified, the tooltip will appear above the sign-out button when hovered over.
chrisleicester
force-pushed
the
CDPE-4655/remove-plus-icon-a11y
branch
from
cb58aae to
6235244
Compare
vine77
suggested changes
Mar 8, 2022
| @@ -31,6 +34,7 @@ const defaultProps = { | |||
| minimized: false, | |||
| profileIcon: null, | |||
| enableSignout: false, | |||
| tooltip: null, | |||
There was a problem hiding this comment.
Some PDS components go ahead and specify default text. Since this is only for the sign out button, what do you think about adding a default like "Sign out"? I might also rename this something like signoutTooltip so no one is confused if it applies to the whole Sidebar.Footer.
There was a problem hiding this comment.
Otherwise, everything else looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if the Sidebar Footer was used and the sign-out
button was present, there was no way to add a tooltip to explain the
usage of this button. This makes it difficult for someone using a screen
reader to find this button and use it.
With this commit, we add an optional parameter to the Sidebar Footer to
specify tooltip text. If specified, the tooltip will appear above the
sign-out button when hovered over.
Screenshot of proposed changes