Skip to content

Add className prop to confirmation modal #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Conversation

Lukeaber
Copy link
Collaborator

Description of proposed changes

Currently we cannot pass classnames to the confirmation modal, this is a bit of an issue as the modal renders separate from the rest of a pages html therefore we cannot change the'rc-modal' classname without risking global css changes

Screenshot of proposed changes

Screenshot 2022-03-10 at 09 16 52

Screenshot 2022-03-10 at 09 17 02

@Lukeaber Lukeaber requested a review from a team as a code owner March 10, 2022 09:21
Copy link
Contributor

@CoMfUcIoS CoMfUcIoS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@CoMfUcIoS CoMfUcIoS merged commit 257f521 into main Mar 10, 2022
@CoMfUcIoS CoMfUcIoS deleted the Add-ClassName-To-Modal branch March 10, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants