Skip to content

PDS-612 Adding custom rows per page #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 26, 2022
Merged

Conversation

cathal41
Copy link
Contributor

Description of proposed changes

Add a new prop to the TableFooter to allow the supply of a custom list of rows per page

Screenshot of proposed changes

N/A

@cathal41 cathal41 requested a review from a team as a code owner July 25, 2022 14:39
Copy link
Contributor

@mardotio mardotio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor things.

Could you also squash your commits so that we don't merge too much noise into main?

@cathal41
Copy link
Contributor Author

Looks good, just a couple of minor things.

Could you also squash your commits so that we don't merge too much noise into main?

I'll do a squash merge when the PR is done

@cathal41 cathal41 requested a review from mardotio July 25, 2022 20:09
@cathal41 cathal41 requested a review from a team July 26, 2022 15:15
@cathal41 cathal41 merged commit 0cf4b6f into main Jul 26, 2022
sean-mckenna added a commit that referenced this pull request Dec 6, 2024
* PDS-612 Adding custom rows per page

* PDS-612 adding git PR numbr to changelog

* PDS-612 Fixing prop description

* PDS-612 removing settings file

* PDS-612 removing recat components bump

* PDS-612 updating package lock

* PDS-612 Adding correct default value for rowsPerPageOptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants