-
Notifications
You must be signed in to change notification settings - Fork 27
PDS-612 Adding custom rows per page #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of minor things.
Could you also squash your commits so that we don't merge too much noise into main?
I'll do a squash merge when the PR is done |
* PDS-612 Adding custom rows per page * PDS-612 adding git PR numbr to changelog * PDS-612 Fixing prop description * PDS-612 removing settings file * PDS-612 removing recat components bump * PDS-612 updating package lock * PDS-612 Adding correct default value for rowsPerPageOptions
Description of proposed changes
Add a new prop to the TableFooter to allow the supply of a custom list of rows per page
Screenshot of proposed changes
N/A