-
Notifications
You must be signed in to change notification settings - Fork 27
Adding optional tooltip to ButtonSelect component #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@alex501212 Any reason you can't just wrap |
I tried doing this but wasn't able to get the tooltip to disappear upon opening the dropdown, so I thought this would be a good way to allow for that |
Gotcha. In that case, could you make it so that the button is only wrapped with the tooltip component if the Also, looks like some tests are failing. |
Tooltip should now conditionally render, also got the tests passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Looks good.
@alex501212 can you just make sure to squash your commits before merging in order to avoid having a bunch of formatting/testing commits in the history.
* added tooltip to buttonSelect * updated changelog and package version * ran prettier * test * changed tooltip defaultprops * added conditional render for tooltip * updated failing snapshot
Description of proposed changes
Added a new optional tooltip to the ButtonSelect component
Updated design system site to reflect changes
Screenshot of proposed changes