Add tag builder options #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukeaber
reviewed
Feb 8, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@puppet/react-components", | |||
| "version": "5.33.9", | |||
| "version": "5.34.9", | |||
There was a problem hiding this comment.
should this not go to 5.34.0 ??
Also make sure to add an entry into the change log to explain whats in this release.
There was a problem hiding this comment.
It should! Thanks, Luke.
Lukeaber
approved these changes
Feb 8, 2023
sean-mckenna
added a commit
that referenced
this pull request
Dec 6, 2024
* Add tag filter * Add focus helpers * Cleanup & lint * Split popup menu into its own component * Add detail component * Update search menu to use Detail component * Add docs and fix issues * Add menu tests * lint * Add lodash to dependencies * Bump & lint * Update snapshot * Update changelog * Fix version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
No breaking changes. Just adding a few components.
Adding:
<Detail />A menu dropdown component we used in Relay and have meant to add. Doing it now because some compliance mocks are using it for the new menus.<Menu />A component for quickly building custom menus and managing menu-item focus. It's not meant to replace theButtonSelector theActionSelect, but it allows us to build more complex & product-specific menus faster going forward.<Menu.Search />Built using the previous two components, it displays and groups options in a searchable/filterable menu. I thought it might be useful outside of Tag-specific usage.<Tag.Search />Built using the previous three components, it usesMenu.Search, for searching tags and displaying the selected ones. The compliance mock can be found hereScreenshot of proposed changes
Detail
Menu
Menu.Search
Tag.Search