Skip to content

Select component props passthrough #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

sean-mckenna
Copy link
Collaborator

@sean-mckenna sean-mckenna commented Jun 24, 2024

  • Allow additional props such as data-testid to be passed to the inner select component.
  • Add more useful select autocomplete styleguide example.
  • Set the input icon button loading style to transparent.

Description of proposed changes

Add example of autocomplete with no match entered

Screenshot 2024-06-24 at 13 25 48

Screenshot of proposed changes

@sean-mckenna sean-mckenna requested a review from Lukeaber June 24, 2024 07:59
@sean-mckenna sean-mckenna requested a review from a team as a code owner June 24, 2024 07:59
@sean-mckenna sean-mckenna force-pushed the select-props-passthrough branch 2 times, most recently from 0c55fcc to 445554e Compare June 24, 2024 08:05
- Allow additional props such as data-testid to be passed to the inner select component.
- Add more useful select autocomplete styleguide example.
- Set the input icon button loading style to transparent.
@sean-mckenna sean-mckenna force-pushed the select-props-passthrough branch from 445554e to 015a272 Compare June 24, 2024 12:21
@sean-mckenna sean-mckenna merged commit 85d053c into main Jun 24, 2024
2 checks passed
sean-mckenna added a commit that referenced this pull request Dec 6, 2024
- Allow additional props such as data-testid to be passed to the inner select component.
- Add more useful select autocomplete styleguide example.
- Set the input icon button loading style to transparent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants