(PA-1941) Fix libnames for new OpenSSL dlls #1503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to copy openssl dlls around on windows. This commit updates the names of those dlls since they changed in OpenSSL 1.1
ekinanp
approved these changes
Aug 4, 2018
| "libeay32.dll", | ||
| platform.architecture == "x64" ? "libgcc_s_seh-1.dll" : "libgcc_s_sjlj-1.dll", | ||
| "ssleay32.dll" | ||
| "libssl-1_1#{ssl_postfix}.dll", |
There was a problem hiding this comment.
Would be cool if this info. was loaded as part of the yaml output for the settings. Maybe something like settings[:imported_libraries][:openssl].
There was a problem hiding this comment.
Guess it won't matter once the PATH'ing stuff is fixed.
There was a problem hiding this comment.
Yeah, at this point the plan is to get pathing fixed soon anyway, so the refactor is unnecessary
|
CLA signed by all contributors. |
mcdonaldseanp
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to copy openssl dlls around on windows. This commit updates the
names of those dlls since they changed in OpenSSL 1.1
Should be merged at the same time as puppetlabs/puppet-runtime#82