Skip to content

(PA-1942) Update OpenSSL to 1.1.0 in puppet-agent#master #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

(PA-1942) Update OpenSSL to 1.1.0 in puppet-agent#master #73

wants to merge 1 commit into from

Conversation

mcdonaldseanp
Copy link
Contributor

No description provided.

@mcdonaldseanp
Copy link
Contributor Author

jenkins please test this with puppet-agent#master on aix61-POWERa,solaris10-64a,solaris10-SPARCa,solaris11-SPARCa,windows2012r2-64a

@mcdonaldseanp
Copy link
Contributor Author

jenkins please test this with puppet-agent#master on ,aix61-POWERfa,amazon6-64a,amazon7-64a,arista4-32a,ciscoxr-64a,cumulus25-64a,debian8-64a,debian8-32a,debian9-64a,debian9-32a,fedora26-64a,fedora27-64a,osx1012-64a,osx1013-64a,redhat5-64a,redhat6-64a,redhat6-32a,redhat7-64a,redhat7-POWERa,redhat7-AARCH64a,redhatfips7-64a,sles11-64a,sles11-32a,sles12-64a,sles12-POWERa,solaris10-64a,solaris10-SPARCa,solaris11-64a,solaris11-SPARCa,ubuntu1404-64a,ubuntu1404-32a,ubuntu1604-64a,ubuntu1604-32a,ubuntu1604-POWERa,ubuntu1804-64a,windows10ent-32a,windows2012r2_ja-64a%7Blocale=ja%7D

@mcdonaldseanp
Copy link
Contributor Author

jenkins please test this with puppet-agent#master on aix61-POWERfa,amazon6-64a,amazon7-64a,arista4-32a,ciscoxr-64a,cumulus25-64a,debian8-64a,debian8-32a,debian9-64a,debian9-32a,fedora26-64a,fedora27-64a,osx1012-64a,osx1013-64a,redhat5-64a,redhat6-64a,redhat6-32a,redhat7-64a,redhat7-POWERa,redhat7-AARCH64a,redhatfips7-64a,sles11-64a,sles11-32a,sles12-64a,sles12-POWERa,solaris10-64a,solaris10-SPARCa,solaris11-64a,solaris11-SPARCa,ubuntu1404-64a,ubuntu1404-32a,ubuntu1604-64a,ubuntu1604-32a,ubuntu1604-POWERa,ubuntu1804-64a,windows10ent-32a,windows2012r2_ja-64a%7Blocale=ja%7D

caseywilliams
caseywilliams reviewed Jun 21, 2018
View reviewed changes
Copy link
Contributor

@caseywilliams caseywilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with other (non-agent) projects that still use openssl 1.0.2? I think they'll need the "openssl-#{settings[:openssl_version]}" build requires too, or a default version set in a _base-openssl.rb file.

configs/projects/_shared-agent-settings.rb Outdated
@@ -196,7 +195,7 @@
'no-dtls1',
'no-idea',
'no-seed',
'no-ssl2-method',
# 'no-ssl2-method',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this option deprecated in 1.1.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I forgot to move this in to ssl version specific settings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@mcdonaldseanp
Copy link
Contributor Author

I think we should make the version selection pretty deliberate, so I made additions to the other projects to pick openssl 1.0.2,

Those projects will have the option to move to 1.1.0 if they so choose, for now this change shouldn't also effect them

@mcdonaldseanp
Copy link
Contributor Author

superseded by #82

@mcdonaldseanp mcdonaldseanp deleted the PA1941 branch August 8, 2018 16:27
witjoh pushed a commit to witjoh/puppet-runtime that referenced this pull request Feb 24, 2021
@bmjen
Merge pull request puppetlabs#73 from bmjen/release-1.1
da89408 
Release 1.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseywilliams caseywilliams caseywilliams left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcdonaldseanp @caseywilliams