(PA-4218) Updates macOS tests #8897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with macOS 10.14 Mojave, Apple require full disk access (FDA) to make changes to certain system functionality, including user ID (UID) and the `/home` directory. Granting FDA means either manual user intervention or creating a Privacy Preferences Policy Control Payload (PPPCP) profile through mobile device management (MDM). This means that these two tests (`should_modify_home.rb` and `should_modify_uid.rb`) don't work on any version of macOS that Puppet supports (10.14-11), so we no longer need them.
mhashizume
force-pushed
the
PA-4218/macos_12_tests
branch
2 times, most recently
from
5aebc88 to
7cce907
Compare
joshcooper
approved these changes
Mar 17, 2022
mhashizume
force-pushed
the
PA-4218/macos_12_tests
branch
from
7cce907 to
2f645e8
Compare
This test excludes all versions of macOS starting from 10.15 Catalina. As Puppet dropped macOS 10.14 Mojave support last year, we no longer have to use a regex matcher as every supported version of macOS can be excluded.
mhashizume
force-pushed
the
PA-4218/macos_12_tests
branch
from
2f645e8 to
270d762
Compare
|
@joshcooper thanks for the review, I made a minor change (changed the regex in Thank you! |
joshcooper
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for macOS 12 Monterey surfaced some issues with existing tests for macOS specifically. This PR