(PUP-11785) Don't fallback to PSON if catalog rendering fails #9054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriaXLi
force-pushed
the
PUP-11785/do_not_fallback_to_pson_in_main
branch
2 times, most recently
from
e282354 to
e98fa36
Compare
joshcooper
reviewed
Apr 14, 2023
Rich data is enabled by default and when attempting to serialize rich data to PSON, there will be data loss since rich data cannot be serialized via PSON. Due to this, this commit sets the default value for :allow_pson_serialization to false for Puppet 8. This means an error will be raised when falling back to PSON. Additionally, some indirected_routes_spec.rb tests were updated to ensure they were properly testing the change and intended behavior.
AriaXLi
force-pushed
the
PUP-11785/do_not_fallback_to_pson_in_main
branch
from
efc6bd0 to
3dd7cd5
Compare
joshcooper
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rich data is enabled by default and when attempting to serialize rich data to PSON, there will be data loss since rich data cannot be serialized via PSON. Due to this, this commit sets the default value for :allow_pson_serialization to false for Puppet 8. This means an error will be raised when falling back to PSON.