Skip to content

[Backport 7.x] Return boolean instead of Beaker::Result #9254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2024
Merged

[Backport 7.x] Return boolean instead of Beaker::Result #9254

merged 1 commit into from
Feb 12, 2024

Conversation

github-actions[bot]
Copy link

Description

Backport of #9253 to 7.x.

@joshcooper @github-actions
Return boolean instead of Beaker::Result
930ae78 
Commit 9f5f8e5 eliminated the global `stdout`, but changed the block to return
whatever the `on` method returned (which was a Beaker::Result object). Since the
object is truthy, RHEL6 wasn't excluded.

(cherry picked from commit 9a55434)
@github-actions github-actions bot requested a review from a team as a code owner February 12, 2024 20:36
@github-actions github-actions bot mentioned this pull request Feb 12, 2024
Merged
@mhashizume mhashizume added the maintenance Maintenance chores are excluded from changelogs label Feb 12, 2024
@mhashizume mhashizume closed this Feb 12, 2024
@mhashizume mhashizume reopened this Feb 12, 2024
@mhashizume mhashizume merged commit 1fff77d into 7.x Feb 12, 2024
@mhashizume mhashizume deleted the backport-9253-to-7.x branch February 12, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhashizume mhashizume mhashizume approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance chores are excluded from changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhashizume @joshcooper