-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add options for failing resource check on command line #9257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joshcooper
merged 2 commits into
puppetlabs:main
from
cthorn42:maint/main/systemd_resource_not_found_error
Feb 28, 2024
Merged
Add options for failing resource check on command line #9257
joshcooper
merged 2 commits into
puppetlabs:main
from
cthorn42:maint/main/systemd_resource_not_found_error
Feb 28, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… will now return error"" This reverts commit 1818d78.
LGTM, could you squash the last two commits? Something like this should do the trick
|
8685a72
to
1a9c299
Compare
joshcooper
reviewed
Feb 22, 2024
1a9c299
to
7fc2806
Compare
joshcooper
reviewed
Feb 23, 2024
7fc2806
to
248dbe5
Compare
joshcooper
approved these changes
Feb 27, 2024
joshcooper
added a commit
that referenced
this pull request
Mar 6, 2024
…urce_service_change Revert "Merge pull request #9257 from cthorn42/maint/main/systemd_res…
alanhargreaves
pushed a commit
to alanhargreaves/puppet
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
puppet resource service
, and the service does not exist, the application will return a 0 exit code and display that the service is not running.This PR introduces a new option for the
puppet resource service
application,--fail
, if the service is not found and the option is used, the application will return with a non-zero exit code, and display an error message.Example of use:
Here is an example without the flag: