Skip to content

Auto enable strict_variables for unit tests when puppet > 3.5 #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Auto enable strict_variables for unit tests when puppet > 3.5 #773

wants to merge 1 commit into from

Conversation

mcanevet
Copy link
Contributor

No description provided.

@mcanevet mcanevet mentioned this pull request Jun 20, 2014
Merged
@apenney
Copy link
Contributor

apenney commented Jun 26, 2014

Can you do a quick rebase for us? can't merge now!

@mcanevet
Copy link
Contributor Author

@apenney done.
Could you please also have a look at similars PR:
voxpupuli/puppet-corosync#72
puppetlabs/puppetlabs-ntp#169
puppetlabs/puppetlabs-postgresql#432

@mcanevet
Copy link
Contributor Author

mcanevet commented Jul 2, 2014

@apenney rebased

@apenney
Copy link
Contributor

apenney commented Jul 3, 2014

Hey, so, we've made a few changes recently to how these files are managed and we haven't really communicated it properly. We're using https://github.com/puppetlabs/modulesync to automatically (well, ok, via PRs right now) update all the modules whenever a change is made to the central templates within modulesync. That means this would just get overwritten in the near future. We've also added strict_variables support within puppetlabs_spec_helper itself as well to make this easier going forward.

So I'm closing this, but feel free to submit PRs over at modulesync :)

@apenney apenney closed this Jul 3, 2014
@mcanevet
Copy link
Contributor Author

mcanevet commented Jul 4, 2014

@apenney done: voxpupuli/modulesync#9

@mcanevet mcanevet deleted the feature/enable_strict_variables branch July 4, 2014 06:46
@cmurphy cmurphy mentioned this pull request Jul 7, 2014
Closed
traylenator pushed a commit to traylenator/puppetlabs-apache that referenced this pull request Jun 7, 2022
@bastelfreak
Merge pull request puppetlabs#773 from smortex/fix/check-for-nil-value
6e81b7e 
Fix facts gathering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcanevet @apenney