(CAT-1731) add rules tests #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramesh7
approved these changes
Jun 5, 2024
remove extensions.json following ci complaints
Within the Puppet Enterprise UI console the concept of pinned nodes
allows more complex rules to be expressed while including pinned nodes.
Pinned nodes are formed by having a top level "or" clause, with
expressions in the form
`['=', 'name', 'hostname']`
Prior to this change, the code would not properly maintain pinned nodes,
nor correctly handle merging expressions like:
```
['and',
['~',
['fact', 'pe_server_version'],
'.+']]
```
with
```
['or', ['~',
['trusted', 'extensions', '1.3.6.1.4.1.34380.1.1.9812'],
'^puppet/']]
```
Incorrectly combining them into an `and` clause when logically they should be an "or" clause.
With this change, pinned nodes are separated our from the other rules
and then recombined later (if they are present) with a top-level "or" clause.
Test are added to demonstrate the behaviors.
Ramesh7
force-pushed
the
CAT-1731-add-rules-tests
branch
from
462b6bb to
edeea19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Within the Puppet Enterprise UI console the concept of pinned nodes
allows more complex rules to be expressed while including pinned nodes.
Pinned nodes are formed by having a top level "or" clause, with
expressions in the form
['=', 'name', 'hostname']Prior to this change, the code would not properly maintain pinned nodes,
nor correctly handle merging expressions like:
with
Incorrectly combining them into an
andclause when logically they should be an "or" clause.With this change, pinned nodes are separated our from the other rules
and then recombined later (if they are present) with a top-level "or" clause.
Test are added to demonstrate the behaviors.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist