Convert the rspec-system tests over to beaker. #114
Merged
+381
−201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| expect(r.stderr).to eq("") | ||
| end | ||
| apply_manifest(pp, :catch_failures => true) do |r| | ||
| expect(r.exit_code).to be_zero |
There was a problem hiding this comment.
You could add another expect(r.stderr).to eq("") here if you want
This converts over the spec tests to be beaker tests. It adds tests for all parameters that were untested previously.
|
Updated with those changes, and the missing ntp_parameters_spec.rb that contains most of the work, whoops. |
apenney
pushed a commit
that referenced
this pull request
Dec 10, 2013
Convert the rspec-system tests over to beaker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts over the spec tests to be beaker tests. It adds tests for
all parameters that were untested previously.