(MODULES-213) Add support for Solaris

[derekmceachern]

Added Solaris section to params.pp. In Solaris there are two packages
to install to support ntp, SUNWntpr and SUNWntpu. (Root and User
packages.)
Adding two files to the $package_name array caused the install class
to fail so install.pp was updated so that the $package_name was the
resource title instead of the name attribute.

This change assumes that the packages are already installed for Solaris. If they
are not then this will fail.

This was tested on Solaris 10 update 10 and on SLES 11 SP3 to ensure that it still works for Linux.

[derekmceachern]

So it looks like I've totally broken the tests with the change to install.pp....

Suggestions on how to make this work for multiple packages?

[hunner]

Thanks for this PR!

You can update the tests to look for a package resource with the title of the $package_name instead of just Package[ntp]. Could you also add a check for the Solaris packages?

[derekmceachern]

I can certainly try, but I'm really new to this.

Is there a way I can run the Travis tests on my own repository before submitting a new pull request so I can make sure it's clean?

[hunner]

If you just update your branch (as you see here) the travis tests will re-run. You don't want to update the .travis.yml though, so you'll want to rebase your d0750ee commit back out. Then you can just git commit --amend and push until they pass.

[hunner]

I submitted #172 with some test changes and other tweaks, but used your manifest commit. Thanks!

[hunner]

Hmm. Our systems are using CSWntp instead of the SUNW packages. I wonder how we should handle that...

[derekmceachern]

Couldn't that be solved with Hiera?

I just did a quick test for one of my nodes, and created the following .yaml file:

---

ntp::package_name:

• "SUNWntpr"
• "SUNWntrux"

And it used those modules instead of the defaults in params.pp.

So, couldn't we leave the SUNW packages and then users can override using hiera?