Various test setup fixes #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically updates our usage of `install_puppet()` to a) specify version numbers (allowing installation on platforms that have native packages but no native dependency resolution) and b) default to installing from gem if no other installation candidate exists for the platform. We also update the creation of a hiera.yaml file to use `echo '' >` instead of `touch` because touch puts in a newline that is encoded in such a way on Debian 7 as to be unparsable by Ruby's YAML parser. And finally we ensure we are setting these and other prerequisites (stdlib) on all hosts, not just the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically updates our usage of
install_puppet()to a) specifyversion numbers (allowing installation on platforms that have native
packages but no native dependency resolution) and b) default to
installing from gem if no other installation candidate exists for the
platform.
We also update the creation of a hiera.yaml file to use
echo '' >instead of
touchbecause touch puts in a newline that is encoded insuch a way on Debian 7 as to be unparsable by Ruby's YAML parser.
And finally we ensure we are setting these and other prerequisites
(stdlib) on all hosts, not just the default.