switch to the 'osfamily' fact #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks for doing this! If you want to add your SuSE support to this pull I'm happy to merge it all at once, or I can merge this and you can add SuSE on top of it. Just let me know. |
|
I just tinkered around with the unit tests... I'll throw SuSE support into this pull request also in just some minutes. |
|
now everything should be fine :) |
|
@rcoleman if you have the time go for it, otherwise I'll try to make time sometime over the next couple of days to review this properly and rebase it. |
|
it should be rebased now |
|
Great, thanks @mmoll! I'll get this merged in after lunch PST. |
ryanycoleman
pushed a commit
that referenced
this pull request
Dec 10, 2012
switch to the 'osfamily' fact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as advised by @branan