Use config_dir for keys_file #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keys_file defaults to /etc/ntp/keys on many platforms, but the packages do not create that directory. There is a parameter, config_dir that can be used to manage this directory, though in our acceptance tests there was a line that did an mkdir of this directory which was removed in PR puppetlabs#314 and covered up the fact that the module would not work by default on many platforms. This should get the tests working again, and update the debian/ubuntu defaults to their documented defaults. Both Debian and Ubuntu actually specify /etc/ntp.keys as the default. And freebsd, sles, opensuse, and archlinux. RedHat is the only OS with /etc/ntp/keys as the true default, against the ntpd standard.
HelenCampbell
pushed a commit
that referenced
this pull request
Mar 14, 2016
Use config_dir for keys_file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keys_file defaults to /etc/ntp/keys on many platforms, but the
packages do not create that directory. There is a parameter, config_dir
that can be used to manage this directory, though in our acceptance
tests there was a line that did an mkdir of this directory which was
removed in PR #314 and covered up the fact that the module would not
work by default on many platforms. This should get the tests working
again, and update the debian/ubuntu defaults to their documented
defaults.
Both Debian and Ubuntu actually specify /etc/ntp.keys as the default.
And freebsd, sles, opensuse, and archlinux.
RedHat is the only OS with /etc/ntp/keys as the true default, against
the ntpd standard.