Demonstrate adding beaker acceptance tests to a module #320
Conversation
As per internal conversations, this is a simple demonstration of running the current acceptance tests on Centos and Ubuntu. This allows for pre-merge testing and aims to help catch some obvious cross-OS issues early.
garethr
force-pushed
the
demonstrate-travis-beaker-tests
branch
from
2742636 to
e46c1e4
Compare
|
👍 Haven't been this excited to hit a merge button in a while! :) |
Demonstrate adding beaker acceptance tests to a module
| docker_cmd: '["/sbin/init"]' | ||
| docker_image_commands: | ||
| - 'rm /usr/sbin/policy-rc.d' | ||
| - 'rm /sbin/initctl; dpkg-divert --rename --remove /sbin/initctl' |
There was a problem hiding this comment.
would you mind explaining what these lines do?
There was a problem hiding this comment.
initctl is from upstart, so I guess this is reverting to sysvinit, but only @garethr can say.
There was a problem hiding this comment.
that would help with getty not leaking, maybe?
There was a problem hiding this comment.
This comes from the upstart Docker hub image https://hub.docker.com/r/dockerimages/ubuntu-upstart/~/dockerfile/
It's required to get upstart to work by being run directly. It removes a fake symlink introduced in the base ubuntu image, then restores the original /sbin/initctl from the package.
There was a problem hiding this comment.
hrm… we should perhaps add .overrides for /etc/init/tty[1-6].conf to disable them so we don't leak them, causing travis to overload.
There was a problem hiding this comment.
travis should give us a new VM for each test run, and the docker container is only started once. so, pfft.
As per internal conversations, this is a simple demonstration of running
the current acceptance tests on Centos and Ubuntu. This allows for
pre-merge testing and aims to help catch some obvious cross-OS issues
early.