Skip to content

Step tickers #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2016
Merged

Step tickers #329

merged 2 commits into from
May 24, 2016

Conversation

jonnytdevops
Copy link
Contributor

No description provided.

The /etc/ntp/step-tickers file is used by `ntpdate` on system boot to
adjust system time before ntp initializes.  The default contents, at
least on RHEL7, point to public pool servers.  If an organization has
internal ntp servers, using internet time servers is undesirable (and
may be firewalled off, anyway).

This adds support for managing the step-tickers file with the value of
the `servers` array used in the `/etc/ntp.conf`.

Spec tests have been updated.
@@ -29,6 +29,12 @@
it { should contain_file('/etc/ntp.conf').with_group('0') }
it { should contain_file('/etc/ntp.conf').with_mode('0644') }

if system == 'RedHat' or system == 'Fedora'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've determined that this can also read if :osfamily == 'RedHat' to accomplish the same check.

@jonnytdevops
Copy link
Contributor Author

@skpy Thanks!

I've made this change, just waiting for travis to run against new commit

Cheers

JT

@@ -29,6 +29,12 @@
it { should contain_file('/etc/ntp.conf').with_group('0') }
it { should contain_file('/etc/ntp.conf').with_mode('0644') }

if :osfamily == 'RedHat'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is always false

@DavidS DavidS merged commit 4068aa2 into puppetlabs:master May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants