Skip to content

(CONT-790) Add Support for Puppet 8 / Drop Support for Puppet 6 #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 6, 2023

Conversation

david22swan
Copy link
Member

No description provided.

@david22swan david22swan force-pushed the CONT-790/main/puppet_8 branch from cdcd6e4 to 48b3fc7 Compare April 5, 2023 13:17
New Versions:
rubocop = 1.48.1
rubocop-performance = 1.16.0
rubocop-rspec = 2.19.0
- Layout/HashAlignment
- Layout/SpaceInsideHashLiteralBraces
- Lint/RedundantCopDisableDirective
- RSpec/MultipleExpectations
@david22swan david22swan force-pushed the CONT-790/main/puppet_8 branch from 48b3fc7 to 0ad4fc3 Compare April 5, 2023 13:23
- Lint/RedundantCopDisableDirective
- RSpec/EmptyLineAfterExample
- RSpec/EmptyLineAfterExampleGroup
- RSpec/EmptyLineAfterHook
- RSpec/ImplicitSubject
- Style/FetchEnvVar
@david22swan david22swan force-pushed the CONT-790/main/puppet_8 branch from 18820cc to 1ef1b3c Compare April 5, 2023 13:42
- Style/TrailingCommaInHashLiteral
- Style/RescueStandardError
- Style/RedundantRegexpEscape
- Style/IfUnlessModifier
@david22swan david22swan force-pushed the CONT-790/main/puppet_8 branch from 43c3708 to 019fe79 Compare April 6, 2023 08:52
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 415862f into puppetlabs:main Apr 6, 2023
@david22swan david22swan deleted the CONT-790/main/puppet_8 branch April 11, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants