hostname task fails if FQDN provided in inventory/params

[johnduarte]

Given that a FQDN is provided in the inventory and the params.json file for a role, the pe_xl::hostname task will throw an error because the hostname returned does not include the domain.

nodes.yaml snippet

...
    nodes:
      - l44n1csrf0zp9s4.delivery.puppetlabs.net
...

params.json snippet

{
...
  "master_host": "l44n1csrf0zp9s4.delivery.puppetlabs.net",
...
}

Plan fails with

...
{"node":"l44n1csrf0zp9s4.delivery.puppetlabs.net","target":"l44n1csrf0zp9s4.delivery.puppetlabs.net","action":"task","object":"pe_xl::hostname","status":"success","result":{"hostname":"l44n1csrf0zp9s4"}}
Command returned successfully
...
{
  "kind": "bolt/plan-failure",
  "msg": "Hostname / DNS name mismatch: target l44n1csrf0zp9s4.delivery.puppetlabs.net reports 'l44n1csrf0zp9s4'",
  "details": {
  }
}

I presume that the hostname task should be producing the fqdn instead of just the base hostname.

Possible update

diff --git a/tasks/hostname.sh b/tasks/hostname.sh
index bdabaf7..f64a4d8 100755
--- a/tasks/hostname.sh
+++ b/tasks/hostname.sh
@@ -1,6 +1,6 @@
 #!/bin/bash

-hostname=$(/usr/bin/hostnamectl --transient)
+hostname=$(/usr/bin/hostname -f)

 # Output a JSON result for ease of Task usage in Puppet Task Plans
 echo '{ "hostname": "'$hostname'" }'