Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding CSR attribute settings #63

Closed
bwilcox opened this issue Feb 21, 2020 · 4 comments
Closed

Allow overriding CSR attribute settings #63

bwilcox opened this issue Feb 21, 2020 · 4 comments

Comments

@bwilcox
Copy link
Contributor

bwilcox commented Feb 21, 2020

Use Case

peadm is opinionated in the use of CSR attributes. Some customers have existing use for these attributes and the ability to override and add attributes would be beneficial.

Describe the Solution You Would Like

The ability to specify attributes and the values used for each host in a deployment.

Describe Alternatives You've Considered

Forking the project and changing the current hard-coded values for another set. But this creates something that requires on-going maintenance effort to keep current with changes.

@cyberious
Copy link

Would love to see this, it is keeping us for using in our existing environment, we use a bunch of the trusted facts including the challenge password for signing of Compile Masters

@cyberious
Copy link

For an example we lay this down in our cloud-init file.

  - path: /etc/puppetlabs/puppet/csr_attributes.yaml
    permissions: '0644'
    content: |
      ---
      csr_attributes:
        extension_requests:
          pp_application: "puppet/${role}"
          pp_environment: ${environment}
          pp_cluster: "${environment}_${cluster}"
          pp_zone: "${zone}"
          pp_cost_center: "${cost_center}"
          pp_role: "${pp_role}"
        custom_attributes:
          challengePassword: "${sslChallenge}"

@bwilcox
Copy link
Contributor Author

bwilcox commented Mar 7, 2020

#69

There's a working example. Might not be the best approach. I'm welcome to suggestions.

@reidmv
Copy link
Contributor

reidmv commented Apr 14, 2020

Fixed in #76

@reidmv reidmv closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants