Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature custom csr attributes #69

Closed
wants to merge 9 commits into from
Closed

Feature custom csr attributes #69

wants to merge 9 commits into from

Conversation

bwilcox
Copy link
Contributor

@bwilcox bwilcox commented Mar 7, 2020

This pull request adds the ability to customize pp_application and pp_cluster values. It also adds code which will cause the agent installer to not overwrite a csr_attributes.yaml file if one already exists.

This is a working example, but I expect there may be other ways that make sense.

@reidmv
Copy link
Contributor

reidmv commented Mar 10, 2020

@bwilcox let's talk about the use case(s) for wanting to do this. As a UX design choice as well as for keeping a tightly prescriptive implementation that will keep upgrades manageable in the event of significant future changes, I generally want to keep the number of configurable parameters very minimal. As such, I'd like to explore what other options we may have for addressing whatever problem this PR solves.

So for discussion: what problem does this solve? 🙂

@bwilcox
Copy link
Contributor Author

bwilcox commented Mar 11, 2020

The first issue is that the existing code completely overwrites any custom csr_attributes.yaml file on infrastructure nodes. So for an enterprise which has a set of established OIDs they want in their certificates, there is no way to get those things into the trusted extensions at install time.

The second issue is that pp_application and pp_cluster are being set with no ability to override. Customers using peadm as a migration tool can already have values for these OIDS.

The first issue I think we absolutely need to address. The second is maybe less so, depending on the customer you're talking to. The node groups setup based on pp_cluster for compilers could be adapted post-install. pp_application on the other hand is commonly used for roles and if a customer already has well established roles for Puppet infrastructure we are introducing a little more headache.

@reidmv
Copy link
Contributor

reidmv commented Mar 21, 2020

I think another approach to the conflict with pp_application and pp_cluster is to use custom OIDs. See #76 for an implementation of that.

@reidmv reidmv closed this in #76 Mar 28, 2020
@bwilcox bwilcox deleted the feature_custom_csr_attributes branch April 6, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants