Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes to convert #125

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Bug fixes to convert #125

merged 2 commits into from
Sep 22, 2020

Conversation

reidmv
Copy link
Contributor

@reidmv reidmv commented Sep 21, 2020

Two things.

  1. Stop the puppet agent before writing the csr_attributes.yaml file. This is to avoid a situation where the Puppet agent might delete or alter the file before a cert request is made.
  2. Check for either the peadm availability group OID, OR use of the pp_cluster OID to identify nodes in A and B availability groups before falling back to simple even/odd indexing.

@reidmv reidmv requested a review from a team as a code owner September 21, 2020 22:29
timidri
timidri approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@timidri timidri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reidmv
Run on primary, then the rest, at end of convert
dbeec01 
So that if the puppetserver process restarts it doesn't impact agent
runs on any of the rest of the nodes
@reidmv reidmv merged commit 8f8f7ed into main Sep 22, 2020
@reidmv reidmv deleted the convert-fixes branch September 23, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timidri timidri timidri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reidmv @timidri