Release 2.5.0 #149
Merged
Release 2.5.0 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires puppetlabs-stdlib version 6.5.0 or newer.
|
@reidmv Although this definitely LGTM, I wonder how to properly test peadm. Is it an idea to add a guide for developers/testers? |
|
@timidri that would be a good idea, yeah. Add also to that idea, add in some BoltSpec tests. At present, the smoke test for peadm is to A) deploy a new cluster; B) upgrade a cluster. |
Cool, then I would propose to create an automatic smoke test with Github Actions or Relay which does exactly that and checks for the outcome. |
Now that WhatsARanjit has released a new version of node_manager
Metadata and Changelog updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR preps for releasing 2.5.0 with a few improvements, and support for PE 2021.0