Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support latest PE release #157

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Support latest PE release #157

merged 3 commits into from
Jun 25, 2021

Conversation

ody
Copy link
Member

@ody ody commented Jun 9, 2021

Sets the upper bound for supported PE to something that matches a
released version of 2021.

@ody ody requested a review from a team as a code owner June 9, 2021 22:10
@reidmv
Copy link
Contributor

reidmv commented Jun 9, 2021

@ody can you update the test matrix in .github/workflows/pr-test.yaml to set the version to deploy with? I think maybe we just add a version, so our matrix tests both the LTS and the STS too.

@ody ody marked this pull request as draft June 9, 2021 22:13
@ody ody force-pushed the support_new_release branch from 1ccd483 to 682a10e Compare June 9, 2021 22:26
@ody ody marked this pull request as ready for review June 9, 2021 22:28
@ody ody requested review from a team and removed request for a team June 9, 2021 22:29
@reidmv
Copy link
Contributor

reidmv commented Jun 9, 2021

Looks like one of the unit tests is failing; the peadm::assert_supported_pe_version() function, specifically. Probably just needs the test updated for the new version. Not sure if there's a way to fix the test to be less finicky.

@ody ody marked this pull request as draft June 9, 2021 22:39
@ody ody marked this pull request as ready for review June 9, 2021 22:44
@ody ody requested review from a team and removed request for a team June 9, 2021 22:45
@ody
Copy link
Member Author

ody commented Jun 9, 2021

Unknown why this failed on 2021.1, deployed to it in the past, will investigate

@ody ody marked this pull request as draft June 9, 2021 23:05
@reidmv reidmv force-pushed the support_new_release branch from ec37d64 to 4ac2ea4 Compare June 17, 2021 05:17
@reidmv reidmv self-requested a review June 17, 2021 05:38
@timidri timidri changed the title Support lates PE release Support latest PE release Jun 17, 2021
ody added 2 commits June 25, 2021 09:48
@ody @reidmv
Support lates PE releases
faeeaf7 
Sets the upper bound for supported PE to something that matches a
released version of 2021.
@ody @reidmv
Update tests to reflect new supported PE range
1f0d9a1
@reidmv reidmv force-pushed the support_new_release branch from 4ac2ea4 to 1f0d9a1 Compare June 25, 2021 16:48
@reidmv
Include LANG in environment variables
8e63c33 
This works around a locale problem on the Github runner, which uses
C.UTF-8 as its default. When that is passed to Puppet/Ruby over
Bolt/SSH, Puppet can implode. Set LANG to en_US.UTF-8 to avoid this
Puppet bug.
@reidmv reidmv force-pushed the support_new_release branch from 0619d20 to 8e63c33 Compare June 25, 2021 20:23
@reidmv reidmv requested review from reidmv and removed request for reidmv June 25, 2021 21:17
@reidmv reidmv marked this pull request as ready for review June 25, 2021 22:07
reidmv
reidmv approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@reidmv reidmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And tests are now passing. 👍

@reidmv reidmv merged commit ca277e9 into puppetlabs:main Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidmv reidmv reidmv approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ody @reidmv @timidri