Replace plan peadm::modify_cert_extensions with peadm::modify_certificate #181
+360
−190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces modify_cert_extensions. It supports modifying DNS alternative names as well.
This supports the new peadm::modify_certificate plan
reidmv
force-pushed
the
modify_certificate
branch
2 times, most recently
from
b161758 to
ee47845
Compare
Previously, it could return null.
Sometimes you may want to forcibly regenerate a certificate even if it already matches the desired state, e.g. if it is expiring soon. This commit also fixes dns-alt-names to more concretely check for existing status matching desired status.
reidmv
force-pushed
the
modify_certificate
branch
from
ee47845 to
9135e8e
Compare
This replaces the deprecated use of peadm::modify_cert_extensions
reidmv
force-pushed
the
modify_certificate
branch
from
5d8f992 to
bc1464a
Compare
davidsandilands
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
There was some very slight lint errrors but all flaws with linting detection rather than anything that needs fixed will approve and merge to have it done and leave to @reidmv if he wants to follow them up or not.
davidsandilands
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the old
peadm::modify_cert_extensionsplan with thepeadm::modify_certificateplan. This plan supports setting DNS alt names, in addition to adjusting other extensions. It's also just a more friendly name.