Add get_peadm_config task #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reidmv Can you comment on what's the easiest workflow to test this? but get as expected. Also, it's still unclear to me how to quickly bootstrap an environment for bolt to find peadm's tasks. I end up creating |
|
@timidri i always do it a bit of a dirty way to hack it together and drop the module in a directory (ensuring its named to only module name and not author-module) and then create a inventory like Then something like works although i think a bolt project file is the correct way to do this |
|
@reidmv thats cleaner although not sure on whats happening with internal compiler address, PROD is large server no compilers no replica, DR is large server 2 compilers no replica. |
This task can introspect an existing cluster (when run on a primary node) and return information about how the cluster is currently configured. This will aid in running plans that need to modify the cluster, by reducing the amount of information the user must supply. The task returns data about the cluster in both primary/replica form, as well as A/B form, since different forms are useful in different scenarios.
Improve the readability of the task, and the task description.
In the event a group doesn't exist, or a key doesn't return a value. Don't error, just return nil for those values.
When this was refactored, the wrong defaults were given to the compiler load balancer address variables. They should default to the A and B *servers*, not the A and B postgresql hosts.
|
The The defaults for those settings are... the values of the In your stack, since it was probably provisioned before we always created the B groups, there probably just aren't values for any of that, in any group. |
reidmv
requested review from
davidsandilands
and removed request for
davidsandilands
Realized this could be a generally useful way of understanding all letter assignments, if we returned compilers as well.
|
Install matrix test action completed successfully with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task can introspect an existing cluster (when run on a primary node) and return information about how the cluster is currently configured. In the future, this can be used to aid in running plans that need to modify the cluster, by reducing the amount of information the user must supply. For example, the add_compiler plan, or (future) add_postgresql.
The task returns data about the cluster in both primary/replica form, as well as A/B form, since different forms are useful in different scenarios.