Remove hardcoded default memory configuration #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A long time ago these settings were added to faciliate local development on VirtualBox, using developer workstations. We should not provide different memory defaults for PE installs than what is provided by PE itself. Additional fix: found Puppet Strings bug which prevented generating a REFERENCE.md file. It is now possible to use Puppet Strings to generate a REFERENCE.md.
mcka1n
suggested changes
Jul 26, 2021
functions/generate_pe_conf.pp
Outdated
| @@ -16,23 +15,26 @@ function peadm::generate_pe_conf ( | |||
| # Define the configuration settings that will be placed in pe.conf by | |||
| # default. These can be overriden by user-supplied values in the $settings | |||
| # hash. | |||
| # | |||
| # At this time, there are no defaults which need to be modified from the | |||
| # out-of-box defaults. | |||
| $defaults = { | |||
There was a problem hiding this comment.
If no one is using this, and there are no use-cases in the near future ... should we remove the whole $defaults hash definition?
There was a problem hiding this comment.
I thought about it, but wondered if there was value in keeping the structure there as scaffolding to save us a little time in the event a future change forces us back into setting some defaults. It doesn't feel like it costs anything to keep it.
Removing for now as there is no need to set peadm-coded default pe.conf configuration values. To restore the ability to inject defaults into generated pe.conf files, revert this commit.
reidmv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long time ago these settings were added to faciliate local development
on VirtualBox, using developer workstations. We should not provide
different memory defaults for PE installs than what is provided by PE
itself.
Additional fix: found Puppet Strings bug which prevented generating a
REFERENCE.md file. It is now possible to use Puppet Strings to generate
a REFERENCE.md.