Add an experimental peadm::uninstall plan #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidmv
suggested changes
Aug 2, 2021
There was a problem hiding this comment.
- Use
pdk bundle execto get the right Ruby version(s), or usepdk test unit - In the event the uninstall script isn't present, we should print an error message stating the problem, and stating that the uninstall task cannot be used to uninstall PE from that target at this time
- Use an absolute path to the uninstall script
- Remove
$versionparameter and check; don't need it for uninstall
.ruby-gemset
Outdated
| @@ -0,0 +1 @@ | |||
| peadm | |||
There was a problem hiding this comment.
Per pdk comments, let's remove this file
.ruby-version
Outdated
| @@ -0,0 +1 @@ | |||
| ruby-2.5.7 | |||
There was a problem hiding this comment.
Per pdk comments, let's remove this file
tasks/pe_uninstall.sh
Outdated
| # and the command-line flags, visit: | ||
| # https://puppet.com/docs/pe/2019.8/uninstalling.html | ||
|
|
||
| sudo ./puppet-enterprise-uninstaller -d -p -y |
There was a problem hiding this comment.
Use an absolute path here, otherwise we'll probably not run the command correctly.
reidmv
reviewed
Aug 2, 2021
Co-authored-by: Reid Vandewiele <[email protected]>
mcka1n
changed the title
mcka1n
changed the title
reidmv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In this PR I'm introducing the
peadm::uninstallBolt plan with a proper spec file