Fix upgrade without replica #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test for when a primary, and a compiler are both given, but no replica is given
Previously, the $target.name was used as the hash key. This was originally done to work around a bug in an older version of Bolt; it is not necessary to use the .name string as the hash key. Using .name makes it more difficult to deal with when there are no actual Target objects in an array. So let's stop doing that.
This fixes the situation where there is no replica, so computing the second compiler group cannot be done due to hitting an array indexing issue. By switching to dig, undef will simply be returned in that situation.
reidmv
force-pushed
the
fix-upgrade-without-replica
branch
from
33a1a1e to
8ef9bd5
Compare
ody
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
Code only contains a single minor logic modification, else just swapping out functions. Think this would have a low potential for causing issues and fixes a bug so seems good to me. Spec test seems straight forward but I've not had the opportunity to get very familiar with spec testing plans so have no substantive feedback on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dan found this bug and commented in Slack. The new test shows the failing situation. The proposed fix is in this draft PR.