(SLV-365) Update the install, configure, and upgrade plans in the pe_xl module to make ha optional #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to reduce the number of `if` statements in code, and remove the need to specify `ha` as a Boolean plan parameter. Instead, do HA if HA systems are specified, and don't if they aren't.
reidmv
force-pushed
the
slv-365_make_ha_optional
branch
from
1396834 to
55bb7c8
Compare
Newer versions of Bolt don't print anything to the screen when running the notice() function. The replacement is out::message().
So that when/if no HA systems are passed, the manifest works correctly. This was a problem in the shell wrapper, not the Puppet code itself.
Wasn't functionally necessary but this is more correct
Not sure where this got lost, but it's a non-operational task without it...
The database systems need to use the installer to set up, but the replica doesn't.
This identifier can help user code know whether or not a node is a master, has resources like Service[pe-nginx], and so make intelligent decisions about whether or not to apply addendum configuration that depends on a node being a master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds an optional ha parameter (default = true) and conditionally performs the HA steps in the install, configure, and upgrade plans. There should be no impact to the existing functionality.
Please see SLV-365 for context regarding the SLV team's need for this feature in provisioning environments for testing with gatling-puppet-load-test.
Additonally, the
provision_pe_xl_nodes.rbscript has been added to GPLT as part of SLV-365 (see SLV-483) to assist in the provisioning of AWS EC2 hosts and creation of thenodes.yamlandparams.jsonfiles for use with pe_xl.