Skip to content

Improve reliability of downloading PE tarball #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 28, 2021
Merged

Improve reliability of downloading PE tarball #215

Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6e16e7f
uses temfile when downloading PE tarball
mcka1n Sep 27, 2021
50ccb74
adds temporary echo lines for debugging
mcka1n Sep 27, 2021
d1ae598
adds spaces around the brackets to meet bash syntax
mcka1n Sep 27, 2021
6f5c612
uses proper quotes around variable
mcka1n Sep 27, 2021
63deb3f
removes -p flag to avoid future mktemp conflicts
mcka1n Sep 27, 2021
4c90d40
uses proper syntax for interpolation
mcka1n Sep 27, 2021
35b05eb
removes unused variable
mcka1n Sep 27, 2021
f1b8f6d
returns 1 if the tarball is invalid
mcka1n Sep 27, 2021
9b3ff97
fixes issue with if condition for tarball
mcka1n Sep 27, 2021
b1ec230
ensures that if curls returns non-zero, the func returns non-zero
mcka1n Sep 28, 2021
87342b4
using the curl's exit code instead of its output
mcka1n Sep 28, 2021
4965f43
removes the name argument from mktemp
mcka1n Sep 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tasks/download.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,16 @@ verify-file() {

download() {
printf '%s\n' "Downloading: ${1}"
curl -s -f -L -o "$2" "$1"
tmp_file=$(mktemp "peadm-download")
echo "Temporary file created at: ${tmp_file}"
curl -s -f -L -o ${tmp_file} "$1"
if [ tar -tzf "${tmp_file}" >/dev/null ]; then
mv "${tmp_file}" "$2"
else
echo "Puppet Enterprise download failed: Invalid tarball"
echo "|_ Removing temporary file: ${tmp_file}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo?

Suggested change
echo "|_ Removing temporary file: ${tmp_file}"
echo "Removing temporary file: ${tmp_file}"

rm "${tmp_file}"
fi
}

download-size-verify() {
Expand Down