Fail agent_install if agent is already installed #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PE bash installer script doesn't support re-configuring an existing agent, which is critical to our use case. Therefore, we should fail if the agent is already installed, since we cannot guarantee correct configuration in that scenario.
reidmv
force-pushed
the
fail-agent_install-on-reinstall
branch
from
36bfd7b to
41e55ad
Compare
|
It looks good to me! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PE bash installer script doesn't support re-configuring an existing
agent, which is critical to our use case. Therefore, we should fail if
the agent is already installed, since we cannot guarantee correct
configuration in that scenario.
Fixes #222