Skip to content

Updates docker to use bolt commands #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 7, 2021
Merged

Conversation

logicminds
Copy link
Contributor

This PR provides some cleanup of the existing docker example scripts and some new abilities.

  • Removes inotify because it wasn't being used and was not good for offline installs
  • Switches to using bolt commands for everything including module dependencies
  • Adds ability hot add many agents to the cluster
  • Other minor cleanup

  * Previously we could spit out logs of what bolt was doing.
    This feature is now natively supported in bolt and there
    is no need for installing inotify and supporting services.

  * Additionally, this adds the old pe installer gpg key

  * Reformats json and yaml files under spec/docker
  * The previously implementation used pdk which ships with an
    older version of bolt.  This allows the user to use the local
    installation of bolt which is the same procedure as using peadm
    directly.

  * This also fixes a few issues around module dependencies and relying
    on the fixtures path.  Users are no longer required to have pdk
    or run bundle commands.  Since this uses pure bolt the entire process
    mimics that of a real installation and usage.

  * Updates install and upgrade scripts to use bolt commands
  * Previously the documentation detailed instructions for
    how to add agents to a docker example cluster.  This
    adds a script to do the dirty work.
@logicminds logicminds requested a review from a team as a code owner October 6, 2021 21:21
@CLAassistant
Copy link

CLAassistant commented Oct 6, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@reidmv reidmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@reidmv
Copy link
Contributor

reidmv commented Oct 7, 2021

@logicminds would you mind checking in with the license bot and signing/verifying the CLA, so we can get our last CI check to turn green?

@logicminds
Copy link
Contributor Author

@logicminds would you mind checking in with the license bot and signing/verifying the CLA, so we can get our last CI check to turn green?

Completed again

@reidmv reidmv merged commit e5e0d61 into puppetlabs:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants